Re: error in 1.6.3 popen.c?

[Mark . Burgess]

On 24 May, Alan Sparks wrote:
> A piece of code that makes little sense from here...
> popen.c lines 129-134:
>     for (i = 0; i < MAXFD; i++)
>        {
>        if (CHILD[i] > 0)
>           {
>           close(CHILD[i]);
>           }
> 
> Later (line 228):
>     CHILD[fileno(pp)] = pid;
> 
> So the value of a CHILD element is a process ID, and it's being
> close()d?
> There's a couple of places this code appears.
> -Alan
> 

Yikes, there are two typos here which "cancel each other out".
THanks for spotting this!

Mark

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  Mark.Burgess@iu.hio.no
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~