help-cfengine
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

another problem in 2.1.18 cfservd


From: Joe Buehler
Subject: another problem in 2.1.18 cfservd
Date: Tue, 10 Jan 2006 14:56:59 -0500
User-agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)

Here is another problem still not fixed in 2.1.18.

cfservd.c line 423:

while(VSYSNAME.nodename[i++] != '.')

This loop should be changed to terminate if a null byte (end of string)
is encountered.  It is running past the end of the array at runtime,
perhaps as a result of the StrStr call bug.

Now that I think about it, it seems as though the following test
is logically wrong:

if (StrStr(VSYSNAME.nodename,ToLowerStr(VDOMAIN)))

What if the nodename happens to be a substring of the domain,
but is not fully qualified?
-- 
Joe Buehler





reply via email to

[Prev in Thread] Current Thread [Next in Thread]