2.1.18 cfservd memory leak

[Joe Buehler]

Looks like one of the leaks reported for 2.1.17 is still
present in 2.1.18:

\"/home/project-releases/tmp/cfengine-2.1.18/src/install.c\", line 6252:
(LEAK_SCOPE)
>>       return;

  Memory leaked leaving scope: malloc(sizeof(struct Item))

  Lost block : 0x200d1988 thru 0x200d19a7 (32 bytes)
               malloc(sizeof(struct Item)), allocated at item.c, 316
                          malloc()  (interface)
                      AppendItem()  item.c, 316
           SplitStringAsItemList()  item.c, 1138
                 AddAuthHostItem()  install.c, 6240
                 InstallAuthPath()  install.c, 6217
                 InstallAuthItem()  install.c, 5173
                HandleServerRule()  parse.c, 909
                           yylex()  cflex.l, 501
                         yyparse()  bison.simple, 432
                       ParseFile()  parse.c, 1051
                  ParseInputFile()  parse.c, 82
                            main()  cfservd.c, 144
                         __start()  crt0main.s

  Stack trace where the error occurred:
                 AddAuthHostItem()  install.c, 6252
                 InstallAuthPath()  install.c, 6217
                 InstallAuthItem()  install.c, 5173
                HandleServerRule()  parse.c, 909
                           yylex()  cflex.l, 501
                         yyparse()  bison.simple, 432
                       ParseFile()  parse.c, 1051
                  ParseInputFile()  parse.c, 82
                            main()  cfservd.c, 144
                         __start()  crt0main.s

\"/home/project-releases/tmp/cfengine-2.1.18/src/install.c\", line 6240:
(LEAK_ASSIGN)
>>    split = SplitStringAsItemList(attribute,LISTSEPARATOR);

  Memory leaked due to pointer reassignment: malloc(sizeof(struct Item))

  Lost block : 0x200d2d28 thru 0x200d2d47 (32 bytes)
               malloc(sizeof(struct Item)), allocated at item.c, 316
                          malloc()  (interface)
                      AppendItem()  item.c, 316
           SplitStringAsItemList()  item.c, 1138
                 AddAuthHostItem()  install.c, 6240
                 InstallAuthPath()  install.c, 6217
                 InstallAuthItem()  install.c, 5173
                HandleServerRule()  parse.c, 909
                           yylex()  cflex.l, 501
                         yyparse()  bison.simple, 432
                       ParseFile()  parse.c, 1051
                  ParseInputFile()  parse.c, 82
                            main()  cfservd.c, 144
                         __start()  crt0main.s

  Stack trace where the error occurred:
                 AddAuthHostItem()  install.c, 6240
                 InstallAuthPath()  install.c, 6217
                 InstallAuthItem()  install.c, 5173
                HandleServerRule()  parse.c, 909
                           yylex()  cflex.l, 501
                         yyparse()  bison.simple, 432
                       ParseFile()  parse.c, 1051
                  ParseInputFile()  parse.c, 82
                            main()  cfservd.c, 144
                         __start()  crt0main.s

-- 
Joe Buehler