Re: [PATCH v3 0/8] Download WSDL for SOAP services from servers

[Michael Albinus]

Felix Lechner <felix.lechner@lease-up.com> writes:

Hi Felix,

>> I don't expect that debbugs.gnu.org or bugs.debian.org will offer a WSDL
>> file any time soon. We must accept this, and use a local file instead
>> for these two servers.
>
> Since you said that the specifications of the two servers diverged [1]
> I split them into two local files.  Either one could be deployed when
> the time is right, independent of the other.
>
> The two files were modified according to your instructions. [1]

Thanks. However, I don't believe these files should live in the debbugs
package. We have already Debbugs.wsdl, and the files would be almost
just a copy of them, w/o any further gain in the package. They would be
worthful when installed on the respective servers.

>> I don't believe we need caching for the WSDL file. It is stable per
>> server (compared with the life time of an Emacs session)
>
> That's not true for me.  As an EXWM user with a stable base system, my
> Emacs sessions often last two months.  In a compromise, I implemented
> caching, which I think is superior to the "defconst debbugs-wsdl", but
> set the defaul expiration to "never."  You should see no change in
> behavior in your use case.

I do expect WSDL stability for much longer periods than just two
months. The last change (beside copyright year adaption) was in 2019. So
I don't see how this caching would improve the package usability.

I understand that you might change the WSDL on your own server more
frequently. But this is just development, and is not useful for the
majority of the users.

>> please ensure that line lengths do not exceed the 80 char width
>
> Thank you for that pointer.  I did, and also took the liberty to
> adjust the code in other places where it did not comply.

Thanks.

> As mentioned above, I need caching.  It is more flexible than the
> current defconst at startup, so I am hoping you might be inclined to
> accept it.  The default is "no expiry," which is similar to loading it
> only once.

As said, it is needed only for development of the package and your
server I believe. Once this is finished, nobody will need caching, but
it complicates the code for other people who want to modify it.

>> In debbugs-servers, replace the :wsdl entry for the two predefined
>> servers with the URL of the local WSDL file.
>
> That's a great idea, but I think there are two hurdles.  First, the
> path in the local file is currently computed in Elisp and may not be
> the same in all client installation.

The sexp used in debbugs-wsdl to determinme the file name works for all
possible client installations since package creation (13 years ago), so
you might use it in the respective :wsdl entries.

> Second, the SOAP client library does not accept the "file://" URI
> method (although it does accept a plain string.)

Then we shall use it w/o the "file://" prefix.

There is another point I should have mentioned already. The debbugs
package, as part of the GNU ELPA repository, requires, that all
contributors give the respective copyright to the FSF. There is a paper
which must be signed.

It looks to me, that you haven't signed such a legal paper yet. Would
you be willing to do so?

Despite of this legal issue, I have committed patches 1 .. 5 to the
debbugs repository in your name. So we don't need to discuss about
further, they are not controversial.

The FSF copyright rule allows tiny patches to be applied w/o legal
papers, and these patches fit this rule :-)

Best regards, Michael.