Re: Sorting buffers with ibuffer

[z0d]

On Nov 26, 11:28 am, "Juanma Barranquero" <lek...@gmail.com> wrote:

Thank you for your help.

> Package: emacs
> Severity: minor
> X-Debbugs-CC: j...@gnu.org
>
>
>
> On Wed, Nov 26, 2008 at 04:29, z0d <peter.bara...@gmail.com> wrote:
> > shell: emacs -q .emacs .ssh/config .Emacs-lisp/init-lisp.el
>
> > M-: (setq-default ibuffer-default-sorting-mode 'major-mode) <RET>
> > M-x ibuffer <RET>
>
> > produces:
>
> >  MR Name                    Size Mode             Filename/Process
> >  -- ----                    ---- ----             ----------------
> > [ Default ]
> >    asdf-skeleton.el        1052 Emacs-Lisp       ~/.Emacs-Lisp/asdf-
> > skeleton.el
> >    config                   488 Conf[Space]      ~/.ssh/config
> >    .emacs                 13170 Emacs-Lisp       ~/.emacs
> >    *scratch*                191 Lisp Interaction
> >  *  *Messages*               142 Fundamental
> >  % *GNU Emacs*              744 Fundamental
>
> >    6 buffers              15787                  3 files, no
> > processes
>
> You're right.
>
> What's happening is that, in fact, ibuffer is not sorting at all,
> because there's a variable ibuffer-sorting-functions-alist that is
> null at that point. That variable is initialized by code in
> ibuf-ext.el; defaulting to 'recency works because that sorting order
> is special-cased in ibuffer.el.
>
> You can workaround the issue by making sure ibuf-ext is loaded, for example:
>
>   emacs -q -l ibuf-ext .emacs .ssh/config .Emacs-lisp/init-lisp.el
>
> but I think ibuffer should take care that the sorting functions' alist
> is properly stuffed.
>
> John, I've considered the attached patch, which checks in
> ibuffer-sort-bufferlist. The alternative I see is to require 'ibuf-ext
> in `ibuffer-mode' if the user modified `ibuffer-default-sorting-mode',
> like
>
>   (set (make-local-variable 'ibuffer-sorting-mode)
>        ibuffer-default-sorting-mode)
>   (unless (eq ibuffer-sorting-mode 'recency)
>     (require 'ibuf-ext))
>
> Are you OK with one of these changes?
>
>   Juanma
>
> Index: lisp/ibuffer.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/ibuffer.el,v
> retrieving revision 1.110
> diff -u -2 -r1.110 ibuffer.el
> --- lisp/ibuffer.el     8 Oct 2008 05:02:09 -0000       1.110
> +++ lisp/ibuffer.el     26 Nov 2008 09:56:30 -0000
> @@ -2192,4 +2192,6 @@
>
>  (defun ibuffer-sort-bufferlist (bmarklist)
> +  (unless ibuffer-sorting-functions-alist
> +    (require 'ibuf-ext))
>    (let* ((sortdat (assq ibuffer-sorting-mode
>                         ibuffer-sorting-functions-alist))