Re: critique: my-first-function

[Emanuel Berg]

"James K. Lowden" <jklowden@speakeasy.net>
writes:

> (defun open-tall-frames ()
>   "Open two tall frames."
>   (interactive)
>   (let ( (frame-parameters 
>         '((width . 80)
>           (height . 60)
>           (minibuffer . t)
>           (window-system . x)))
>        (frame1 (make-frame frame-parameters))
>        (frame2 (make-frame frame-parameters))
>        )
>   (set-frame-position frame1 -1 0)
>   (set-frame-position frame2 (- (frame-pixel-width frame1)) 0)
> ))

`let' should be `let*' since "frame-parameters"
are used inside the same `let'.

Some more subjective views:

As for style, I think you can align the
data items (lines 5-8).

Instead of "frame1" "frame2", name them after
some property.

And, on line 13, there is a computation, which
I would name and put in the `let' clause as
well. So you set up all data there, and then
only have execution below the `let' - makes it
look good.

-- 
underground experts united .... http://user.it.uu.se/~embe8573
Emacs Gnus Blogomatic ......... http://user.it.uu.se/~embe8573/blogomatic
                   - so far: 48 Blogomatic articles -