Re: Build failure caused by a .tit file

[Göktuğ Kayaalp]

On 2017-04-18 15:41 +0300, Göktuğ Kayaalp <self@gkayaalp.com> wrote:
> diff --git a/lisp/international/titdic-cnv.el 
> b/lisp/international/titdic-cnv.el
> index 130bc74..6a593e2 100644
> --- a/lisp/international/titdic-cnv.el
> +++ b/lisp/international/titdic-cnv.el
> @@ -474,7 +474,6 @@ titdic-convert
>      (with-temp-file  (tit-make-quail-package-file-name filename dirname)
>        (let ((standard-output (current-buffer)))
>       (with-temp-buffer
> -       (set-buffer-multibyte nil)
>         ;; Here we must use `raw-text' instead of `no-conversion' to
>         ;; enable auto-decoding of eol format (CRLF->LF).
>         (let ((coding-system-for-read 'raw-text))

A better version of this one is as follows, which removes the
complementary set-buffer-multibyte call:

diff --git a/lisp/international/titdic-cnv.el b/lisp/international/titdic-cnv.el
index 130bc74..aa6e4f1 100644
--- a/lisp/international/titdic-cnv.el
+++ b/lisp/international/titdic-cnv.el
@@ -474,7 +474,6 @@ titdic-convert
     (with-temp-file  (tit-make-quail-package-file-name filename dirname)
       (let ((standard-output (current-buffer)))
        (with-temp-buffer
-         (set-buffer-multibyte nil)
          ;; Here we must use `raw-text' instead of `no-conversion' to
          ;; enable auto-decoding of eol format (CRLF->LF).
          (let ((coding-system-for-read 'raw-text))
@@ -504,7 +503,6 @@ titdic-convert
                  (coding-system-change-eol-conversion coding-system 'unix))
            (remove-text-properties (point-min) (point-max) '(charset nil)))
 
-         (set-buffer-multibyte t)
          ;; Set point the starting position of the body part.
          (goto-char (point-min))
          (if (not (search-forward "\nBEGIN" nil t))

BTW I did manage to successfully build with this patch applied.  Maybe
that second call should happen before the first call to the search
forward, i.e. just after the let form in the first hunk.

Now I get this weird warning, I can report that elsewhere if not
expected:

Error (initialization): Creation of the default fontsets failed: (error
Invalid script or charset name: old-italic)

This is from a build of master as of yesterday (edc63bf).  I don't get
this with 25.1.

--gk.