Re: DWIM region (was: Re: count regexp hits)

[Marcin Borkowski]

On 2018-01-07, at 07:45, Emanuel Berg <moasen@zoho.com> wrote:

> Marcin Borkowski wrote:
>
>> spacing is kind of strange.
>
> "spacing"?

(defun count-regexp-hits (regexp)
  (interactive "sregexp: ")
  (let*((region (if mark-active
                    `(,(region-beginning) ,(region-end))
                  `(,(point-min) ,(point-max)) ))
        (start (car  region))
        (end   (cadr region)) )
    (count-matches regexp start end t) ))

1. Lack of space after `let*'.

2. Unnecessary space before `))` (twice).

3. Unnecessary double spaces in lines with `start' and `end' (I
understand their purpose, but my OCD does not like them anyway).

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University