Re: on ESHELL, utf-8 and fossil command-line commit message

[Wayne Harris]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sat, 01 Oct 2022 16:09:41 -0300
>> From:  Wayne Harris via Users list for the GNU Emacs text editor 
>> <help-gnu-emacs@gnu.org>
>> 
>> > Maybe you have other customizations that cause this.  What does the
>> > below say:
>> >
>> >   M-: default-process-coding-system RET
>> 
>> It says 
>> 
>> %(print default-process-coding-system)
>> (utf-8-dos . utf-8-unix)
>> %
>> 
>> I tried to change it to just cp1252.
>> 
>> --8<---------------cut here---------------start------------->8---
>> %(setq default-process-coding-system (cons 'cp1252 'cp1252))
>
> Too late, I think.
>
> So I think the problem is that your customizations set up UTF-8
> everywhere, and that causes the problems.  My suggestion is to start
> from "emacs -Q", and if these commands work there, review your
> customizations until you find those which get in the way.
>
> If even "emacs -Q" doesn't work, I suggest to submit a bug report with
> all the details.

Okay.  We get the same result with ``emacs -Q''.

c:/my/path $ alias fs 'fossil $*'
c:/my/path $ echo kkk >> encoding.txt 
c:/my/path $ fs changes
EDITED     encoding.txt

c:/my/path $ (print default-process-coding-system)
(undecided-dos . undecided-unix)

c:/my/path $ (or buffer-file-coding-system "it is nil")
it is nil

c:/my/path $ fs commit -m 'Naiveté'
[...]
Sync done, wire bytes sent: 3234  received: 309  ip: 5.161.138.46

c:/my/path $ fs timeline -n 1
=== 2022-10-02 ===
13:11:20 [febbbf0441] *CURRENT* Naiveté (user: mer tags: trunk)
--- entry limit (1) reached ---
c:/my/path $ 

I then tried to set the ESHELL buffer to utf-8, but I think the encoding
is mangled on the way to the server, so when it comes back it's already
too late.  (No change when viewing the timeline.)

> In general, in core we don't pass arbitrary text via command-line
> arguments on MS-Windows; instead, we write text to a temporary file
> and ask the program to read text from there -- for this very reason.
> Most VCS commands accept -f or -F switch telling them to read the log
> message from a file; I suggest to use that instead of fighting the
> UTF-8 uphill battle.

I'll not do commits on the command-line anymore.

>> %fs timeline -n 1
>> === 2022-10-01 ===
>> 19:04:34 [d992644b4b] *CURRENT* Naiveté. (user: mer tags: trunk)
>> --- entry limit (1) reached ---
>
> Could it be that 'fs' expects UTF-8?

I don't know.  I have only a few weeks of experience with it.  By the
way, ``fs'' is my alias for ``fossil'' (https://fossil-scm.org/).

> Is that a native Windows port or a Cygwin port?

It looks native to me.

%file c:/my/path/to/bin/fossil.exe
c:/my/path/to/bin/fossil.exe: PE32+ executable (console) x86-64, for MS Windows

%ldd c:/my/path/to/bin/fossil.exe
        ntdll.dll => /c/WINDOWS/SYSTEM32/ntdll.dll (0x7ffbe0ef0000)
        KERNEL32.DLL => /c/WINDOWS/System32/KERNEL32.DLL (0x7ffbe0c30000)
        KERNELBASE.dll => /c/WINDOWS/System32/KERNELBASE.dll (0x7ffbde940000)
        WS2_32.dll => /c/WINDOWS/System32/WS2_32.dll (0x7ffbe0140000)
        RPCRT4.dll => /c/WINDOWS/System32/RPCRT4.dll (0x7ffbdf610000)
        ADVAPI32.dll => /c/WINDOWS/System32/ADVAPI32.dll (0x7ffbe0820000)
        msvcrt.dll => /c/WINDOWS/System32/msvcrt.dll (0x7ffbdeff0000)
        sechost.dll => /c/WINDOWS/System32/sechost.dll (0x7ffbe0cf0000)
        USER32.dll => /c/WINDOWS/System32/USER32.dll (0x7ffbe0270000)
        win32u.dll => /c/WINDOWS/System32/win32u.dll (0x7ffbde6f0000)
        GDI32.dll => /c/WINDOWS/System32/GDI32.dll (0x7ffbdf5e0000)
        DNSAPI.dll => /c/WINDOWS/SYSTEM32/DNSAPI.dll (0x7ffbddaa0000)
        gdi32full.dll => /c/WINDOWS/System32/gdi32full.dll (0x7ffbdecf0000)
        msvcp_win.dll => /c/WINDOWS/System32/msvcp_win.dll (0x7ffbde720000)
        ucrtbase.dll => /c/WINDOWS/System32/ucrtbase.dll (0x7ffbde7c0000)
        CRYPT32.dll => /c/WINDOWS/System32/CRYPT32.dll (0x7ffbdee00000)
        bcrypt.dll => /c/WINDOWS/System32/bcrypt.dll (0x7ffbdecc0000)

> The latter will probably expect UTF-8 on the command line, and you
> cannot give it that.

It seems to me that Windows is mangling the command-line bytes.  Why
does it do that?  Is it trying to be helpful?