Re: Run `window-configuration-change-hook` in Lisp code?

[James Cherti]

Hello Stefan,

Here is a summary of an email I sent to emacs-devel (Subject: Should 
text-scale trigger hooks?): I have identified an issue that affects 
Emacs packages such as eat (terminal) and visual-fill-column. Functions 
like `text-scale-increase`, `text-scale-decrease`, and `text-scale-set` 
do not trigger hooks like `window-configuration-change-hook`. As a 
result, the eat package does not immediately update the window when the 
text scale is changed, and visual-fill-column does not update the margin 
right away (it updates only after the window is resized).

The workaround to fix this issue is to call the following after the text 
scale is changed:
(run-hooks 'window-configuration-change-hook)

OP wants to know whether it is good practice or bad practice to run the 
`window-configuration-change-hook` hooks from a third-party package in 
this situation, as a workaround to resolve the issue described above. 
(Check: https://codeberg.org/joostkremers/visual-fill-column/pulls/16 ).

--
James Cherti
https://www.jamescherti.com/

On 2024-11-06 23:47, Stefan Monnier via Users list for the GNU Emacs 
text editor wrote:
> > Something that just came up: is it OK to run
> > `window-configuration-change-hook` in Lisp code? The doc string says
> > "Functions called during redisplay when window configuration has changed",
> > which gives me the impression that it's *only* meant to be run during
> > redisplay, i.e., not during Lisp code.
>
> That description describes when the C code runs this hook.
> Do you want to run this hook yourself manually at other times?
> If so, why?
>
>
>          Stefan