Help packaging network-manager-sstp and sstp-client

[Lars Rustand]

Hello, I'm trying to package network-manager-sstp (and its dependency
sstp-client), but I'm running into a weird error. I'm sure it is a very
easy problem to solve for someone with a little more experience with the
build-system.

>From what I can tell these packages should be fairly standard autotools
projects, but I have no real experience in using autotools neither in
Guix packages nor elsewhere so I don't know what I'm doing here.

I would greatly appreciate it if someone could help me take a look at
the packages and help me build them successfully.

sstp-client is failing with the following error:

--8<---------------cut here---------------start------------->8---
./autogen.sh: ./configure: /bin/sh: bad interpreter: No such file or directory
error: in phase 'bootstrap': uncaught exception:
%exception #<&invoke-error program: "./autogen.sh" arguments: () exit-status: 
126 term-signal: #f stop-signal: #f>
phase `bootstrap' failed after 5.6 seconds
command "./autogen.sh" failed with status 126
--8<---------------cut here---------------end--------------->8---

Which is weird, since /bin/sh does exist, but it should also have been
told to use something else I think.


And network-manager-sstp fails with:

--8<---------------cut here---------------start------------->8---
checking for find... yes
./configure: line 13451: syntax error near unexpected token `fcntl.h'
./configure: line 13451: `      fcntl.h'
error: in phase 'configure': uncaught exception:
%exception #<&invoke-error program: 
"/gnu/store/m6c5hgqg569mbcjjbp8l8m7q82ascpdl-bash-5.1.16/bin/bash" arguments: 
("./configure" 
"CONFIG_SHELL=/gnu/store/m6c5hgqg569mbcjjbp8l8m7q82ascpdl-bash-5.1.16/bin/bash" 
"SHELL=/gnu/store/m6c5hgqg569mbcjjbp8l8m7q82ascpdl-bash-5.1.16/bin/bash" 
"--prefix=/gnu/store/rly5wz0vmbfawl7xiwdkgphsjwz8lgzm-network-manager-sstp-1.3.2"
 "--enable-fast-install" "--build=x86_64-unknown-linux-gnu") exit-status: 2 
term-signal: #f stop-signal: #f>
phase `configure' failed after 1.5 seconds
command "/gnu/store/m6c5hgqg569mbcjjbp8l8m7q82ascpdl-bash-5.1.16/bin/bash" 
"./configure" 
"CONFIG_SHELL=/gnu/store/m6c5hgqg569mbcjjbp8l8m7q82ascpdl-bash-5.1.16/bin/bash" 
"SHELL=/gnu/store/m6c5hgqg569mbcjjbp8l8m7q82ascpdl-bash-5.1.16/bin/bash" 
"--prefix=/gnu/store/rly5wz0vmbfawl7xiwdkgphsjwz8lgzm-network-manager-sstp-1.3.2"
 "--enable-fast-install" "--build=x86_64-unknown-linux-gnu" failed with status 2
--8<---------------cut here---------------end--------------->8---

I checked the configure script in question and this is how it looks at
that location:

--8<---------------cut here---------------start------------->8---
for ac_header in
      fcntl.h
      paths.h
      syslog.h
      stdarg.h
      stdbool.h
      sys/ioctl.h
      unistd.h
do :
--8<---------------cut here---------------end--------------->8---

I don't know what is causing the syntax error, maybe it is the newlines?
Anyway, if I try to build it manually instead the configure script does
not contain these lines and do not fail at this step. I think there must
be some flag that is passed to autoconf that is causing this.


My package definitions look like this:

--8<---------------cut here---------------start------------->8---
(define-public sstp-client
  (package
    (name "sstp-client")
    (version "1.0.19")
    (source
     (origin
       (method git-fetch)
       (uri
        (git-reference
         (url "https://gitlab.com/sstp-project/sstp-client";)
         (commit version)))
       (file-name (git-file-name name version))
       (sha256
        (base32 "09sh414gwbd93ql47f7yignprsgj4x0jrfbcf60pgkhfw8rxb1jc"))))
  (build-system gnu-build-system)
  (native-inputs
   (list autoconf
         automake
         gnu-gettext
         libtool
         pkg-config
         m4
         flex
         intltool
         gtk-doc
         ppp))
  (home-page "")
  (synopsis "")
  (description "")
  (license license:gpl2)))

(define-public network-manager-sstp
  (package
    (name "network-manager-sstp")
    (version "1.3.2")
    (source
     (origin
       (method git-fetch)
       (uri
        (git-reference
         (url "https://gitlab.gnome.org/GNOME/network-manager-sstp";)
         (commit (string-append "release-" version))))
       (file-name (git-file-name name version))
       (sha256
        (base32 "1jpjqn6074lfs7mvlxs9x7ini2xcr87b4vb47kjz7am35pxgj64l"))))
  (build-system gnu-build-system)
  (native-inputs
   (list autoconf
         automake
         gnu-gettext
         libtool
         pkg-config
         m4
         flex
         bash
         intltool
         gtk-doc
         ppp))
  (home-page "")
  (synopsis "")
  (description "")
  (license license:gpl2)))
--8<---------------cut here---------------end--------------->8---