Re: [PATCH] add missing config.h #includes

[Simon Josefsson]

Joe Orton <address@hidden> writes:

> On Thu, Jun 01, 2006 at 04:25:26PM +0200, Simon Josefsson wrote:
>> Joe Orton <address@hidden> writes:
>> 
>> > config.h is not getting included before gettext.h in a few places, so 
>> > the !ENABLE_NLS definitions get used even if NLS is enabled.
>> 
>> Applied, thanks!
>> 
>> Please tell me whether
>> 
>> http://josefsson.org/daily/libidn/libidn-20060601.tar.gz
>> 
>> solves the problem, and I'll release 0.6.4.
>
> That looks fine, thanks.
>
> BTW there are a bunch of warnings in libidn on x86_64 of the nature:
>
> idn.c:142: warning: format ‘%d’ expects type ‘int’, but argument 3 has type 
> ‘size_t’
>
> there are various ways to fix this, not sure what you'd prefer.  Using 
> %ld/%lu to print {s,}size_t values is the simplest if not 100% correct.

Using %lu and casting size_t to (unsigned long) seem as correct as I
can think of, please try the updated daily build (same link as above).

If someone has a better idea on how to print size_t values in printf
in the most portable way, I'm interested...

Thanks,
Simon