Re: libidn 1.23

[Simon Josefsson]

Bruno Haible <address@hidden> writes:

> * AIX 5.1
> * AIX 7.1
> * HP-UX 11.00
> * Solaris 7
> * Solaris 8
> * Solaris 9
>
> Build failure:
>
> Making check in lib/gltests
> ...
>   CC     putenv.o
> "./unistd.h", line 121.11: 1506-296 (S) #include file <getopt.h> not found.
> make: 1254-004 The error code from the last command is 1.
>
> The build directory contains the files
>
>   lib/gltests/unistd.h
>   win32/include/unistd.h
>   gl/unistd.h
>
>   gl/getopt.h
>
> The complete command line is
>
> xlc -D_ALL_SOURCE -O -DHAVE_CONFIG_H -I. -I../..  -DIN_LIBIDN_GNULIB_TESTS=1 
> -I. -I. -I../.. -I./../.. -I../../lib/gl -I./../../lib/gl -D_THREAD_SAFE 
> -I/home/haible/prefix-aix51-cc/include  -g -c -o putenv.o putenv.c
> "./unistd.h", line 121.11: 1506-296 (S) #include file <getopt.h> not found.
> gmake[3]: *** [putenv.o] Error 1
>
> As you can see, a -I../../gl option is missing.

The Makefile.am there is generated by gnulib.  The problem here was
caused by the self-tests for the gnulib instance in lib/ is pulling in
unistd.h and the gnulib instance in ./ needs unistd+getopt.  So the
unistd.h copy in lib/gltests/ ends up including getopt.h (since it
shares the same m4 code), even though it is not needed there, and
getopt.h wasn't copied into lib/gltests/.

I solved it by using gnulib's gl_MAKEFILE_NAME to cause an indirection
to add the necessary -I's in lib/gltests/.

/Simon