Bug#881915: libidn FTBFS with gtk-doc-tools 1.26: gtkdoc-mktmpl is no longer available

[Simon McVittie]

On Sat, 18 Nov 2017 at 18:35:38 +0200, Adrian Bunk wrote:
> On Sat, Nov 18, 2017 at 09:36:58AM +0100, Helmut Grohne wrote:
> >...
> > +override_dh_autoreconf:
> > +   rm -f gtk-doc.make
> > +   gtkdocize
> > +   dh_autoreconf
> >...
> 
> The "rm -f gtk-doc.make" has to be done when cleaning,
> not in autoreconf.

dh_autoreconf_clean is meant to delete whatever was changed by
dh_autoreconf if it is given a script to run instead of autoreconf,
typically either "NOCONFIGURE=1 ./autogen.sh" using upstream's autogen.sh,
or a debian/autogen.sh containing gtkdocize and autoreconf -fi. The man
page briefly mentions this method, and src:flatpak in unstable is an
example of it in use. Is that a valid approach, or is there a reason
why explicitly deleting the file during clean should be preferred?
I'd like to document whichever one is best-practice a bit more clearly.

It looks as though plain gtkdocize replaces gtk-doc.make with a symbolic
link, which dh-autoreconf won't delete (bug filed), breaking the ability
to build twice in a row; so gtkdocize --copy (which works like I expected)
is probably better, at least until/unless dh-autoreconf can be taught
to remove files that were replaced with a symlink. I've changed flatpak
in git to use gtkdocize --copy.

Helmut: similarly, is there a reason that I'm not seeing why explicitly
removing gtk-doc.make before gtkdocize was necessary, or were you only
doing that as a way to be completely sure that the old one wasn't used, or
was it a workaround for gtkdocize turning the plain file into a symlink?

I can confirm that using the same approach as in src:flatpak (but with
gtkdocize --copy) makes libidn2 build correctly, producing binaries
that should be functionally identical to what the maintainer uploaded
(diffoscope reports only trivial differences). Patches attached.

Regards,
    smcv

0001-Fix-FTBFS-gtkdocize-and-add-dblatex-to-Build-Depends.patch
Description: Text Data

0002-Run-gtkdocize-via-debian-autogen.sh.patch
Description: Text Data