Re: [Help-librejs] [Bug-librejs] Supporting <link rel="jslicense">

[Loic J. Duros]

Actually, I'm going to run this by the boss, since I'm not sure we want
to encourage web developers to hide the link. One thing LibreJS could do
is force the link to be displayed. This way anyone with LibreJS would
actually see the link, even if the CSS on the page attempts to hide it.

Sebastian Noack <address@hidden> writes:

> Hi,
>
> a lot of websites (including https://www.eff.org/) hide the web labels link
> anyway with CSS. So why don't let people use a link-tag as an alternative to
> an a-tag to specify their web labels page, in case they don't want have a
> visible link? We can't force them to show the link anyway, but hiding it with
> CSS looks like a hack, since that is what the link-tag is for. You find the
> patch in the attachment.
>
> Cheers
> Sebastian
>
>
> diff -Naur 
> /tmp/librejs-5.4.1.old/lib/html_script_finder/web_labels/js_web_labels.js 
> /tmp/librejs-5.4.1.new/lib/html_script_finder/web_labels/js_web_labels.js
> --- /tmp/librejs-5.4.1.old/lib/html_script_finder/web_labels/js_web_labels.js 
> 2013-10-26 00:35:13.000000000 +0200
> +++ /tmp/librejs-5.4.1.new/lib/html_script_finder/web_labels/js_web_labels.js 
> 2014-02-04 22:43:58.723030048 +0100
> @@ -86,7 +86,7 @@
>  
>    searchForJsLink: function () {
>         //console.log('triggered searchForJsLink');
> -       var linkTags = this.dom.getElementsByTagName('a'),
> +       var linkTags = this.dom.querySelectorAll('a,link'),
>             i = 0,
>             len = linkTags.length,
>             path;