help-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

suspicious code in remake.c


From: Boris Kolpackov
Subject: suspicious code in remake.c
Date: Wed, 21 Apr 2004 12:40:42 -0500
User-agent: Mutt/1.5.4i

Hi Paul,

There is a bit of code in remake.c:update_file around line 324 that 
looks like this:

  /* Process the remaining rules in the double colon chain so they're marked
     considered.  Start their prerequisites, too.  */
  for (; f != 0 ; f = f->prev)
    {
      struct dep *d;

      f->considered = considered;

      for (d = f->deps; d != 0; d = d->next)
        status |= update_file (d->file, depth + 1);
    }

I was wondering shouldn't it be

  if (file->double_colon) 
    for (; f != 0 ; f = f->prev)
  ...

?

thanks,
-boris

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]