3.99.92 build issue

[balducci]

hello,


apologies if I am missing some blatant point here

Just built 3.99.92 and found the following problem.

guile.c compilation fails with:

--8<---------------
guile.c: In function 'guile_define_module':
guile.c:75:47: error: 'scm_t_subr' undeclared (first use in this function)
   scm_c_define_gsubr ("gmk-expand", 1, 0, 0, (scm_t_subr) 
guile_expand_wrapper);
                                               ^
guile.c:75:47: note: each undeclared identifier is reported only once for each 
function it appears in
guile.c:75:59: error: expected ')' before 'guile_expand_wrapper'
   scm_c_define_gsubr ("gmk-expand", 1, 0, 0, (scm_t_subr) 
guile_expand_wrapper);
                                                           ^
guile.c:78:57: error: expected ')' before 'guile_eval_wrapper'
   scm_c_define_gsubr ("gmk-eval", 1, 0, 0, (scm_t_subr) guile_eval_wrapper);
                                                         ^
--8<---------------

OTOH, build of 3.99.91 was fine.

It turns out that the error is due to building against guile-1.8

Actually, diff shows:

--8<---------------
:126> diff ./make-3.99.91/guile.c ../make-3.99.92/guile.c 
20a21
> #include "filedef.h"
74c75
<   scm_c_define_gsubr ("gmk-expand", 1, 0, 0, guile_expand_wrapper);
---
>   scm_c_define_gsubr ("gmk-expand", 1, 0, 0, (scm_t_subr) 
> guile_expand_wrapper);
77c78
<   scm_c_define_gsubr ("gmk-eval", 1, 0, 0, guile_eval_wrapper);
---
>   scm_c_define_gsubr ("gmk-eval", 1, 0, 0, (scm_t_subr) guile_eval_wrapper);
108a110,118
>   static int init = 0;
> 
>   if (! init)
>     {
>       /* Initialize the Guile interpreter.  */
>       scm_with_guile (guile_init, NULL);
>       init = 1;
>     }
> 
122,124d131
<   /* Initialize the Guile interpreter.  */
<   scm_with_guile (guile_init, NULL);
< 
--8<---------------



As far as I seem to understand, scm_t_subr is present in guile-2.0 only,
but configure is happy with guile-1.8, which then causes the above
error (the above diff also explains to me why I had no problems with
3.99.91).

Shouldn't configure for 3.99.92 explicitly require guile-2.0?

Or support for guile-1.8 is still wanted and then use of scm_t_subr
should be avoided?


Hope that this report is of some use and THANKS a lot for your work!


ciao
gabriele