Re: Textscan and csv fitness data problem

[Ben Abbott]

> On Jan 1, 2018, at 11:51 AM, PhilipNienhuis <address@hidden> wrote:
> 
> NJank wrote
>> On Jan 1, 2018 12:13 PM, "PhilipNienhuis" &lt;
> 
>> pr.nienhuis@
> 
>> &gt; wrote:
>> 
>> NJank wrote
>>> On Jan 1, 2018 9:06 AM, "Thomas Esbensen"
>> 
>> 
>> As to textscan, Dan did a lot of good work lately, I think the bugs you
>> implied have been fixed in the development branch.
>> 
>> 
>> Yeah, i noticed that. Would those make it into a 4.2.2 or not until 4.4.0?
>> Been keeping my fingers crossed that it would suddenly "just work" and I
>> wouldn't have to dive into his data again.
> 
> Have a look in the log: http://hg.savannah.gnu.org/hgweb/octave
> bugs 52116 and 52479 have been fixed on stable, the last one (bug 52550)
> not. If you want you can ask in the latter bug report to backport it to
> stable.
> 
> As to csv2cell's erroneous column conversion, I've fixed that stupid bug and
> pushed it. To use it, get csv2cell.cc from here:
> 
> http://hg.code.sf.net/p/octave/io/file/31b7ff5ee040/src/csv2cell.cc
> 
> and then do
> 
> mkoctfile csv2cell.cc
> 
> to build a fixed version. Swap it into place, using 
> "pkg load io; which csv2cell" 
> to find out where it should live, followed by 
> "pkg unload io; clear -f"
> to clear the way for copying (otherwise csv2cell.oct is locked), and then
> copy csv2cell.oct into place.
> 
> Philip

With 4.2.1 I get errors.

csv2cell.cc:228:40: error: no member named 'isnumeric' in 'octave_value'
  long hlines = (nargin > 1 && args(1).isnumeric () ? args(1).long_value() : 0);
                               ~~~~~~~ ^
csv2cell.cc:229:39: error: no member named 'isnumeric' in 'octave_value'
  int arg_sh = (nargin > 1 && args(1).isnumeric () ? 1 : 0);
                              ~~~~~~~ ^

Does the patched version only work on the default branch?

Ben