Re: [Help-smalltalk] More blox fixes...

[Paolo Bonzini]

Patch review comes...

> diff -p smalltalk-2.0k.ori/browser/BrowserMain.st
smalltalk-2.0k/browser/BrowserMain.st
> *** smalltalk-2.0k.ori/browser/BrowserMain.st Tue Feb 25 18:56:54 2003
> --- smalltalk-2.0k/browser/BrowserMain.st Fri Feb 28 18:24:38 2003
> *************** quit
> *** 155,164 ****
>
>   saveImageAs
>       "Save a snapshot on a file the user chooses."
>       fileName := Prompter
> !                 saveFileName: 'File out category'
>                   default: ImageFileName
> -                 in: listView.
>       fileName isNil
>           ifFalse:
>               [ObjectMemory snapshot: fileName.
> --- 155,165 ----
>
>   saveImageAs
>       "Save a snapshot on a file the user chooses."
> +     | fileName |
>       fileName := Prompter
> !                 saveFileName: 'Save image as:'
>                   default: ImageFileName
> !                 in: Shell.
>       fileName isNil
>           ifFalse:
>               [ObjectMemory snapshot: fileName.
>

Ehm... three errors in ten lines.  Sometimes I'm really dumb.

> diff -p smalltalk-2.0k.ori/browser/ClassHierBrow.st
smalltalk-2.0k/browser/ClassHierBrow.st
> *** smalltalk-2.0k.ori/browser/ClassHierBrow.st Tue Feb 25 18:53:57 2003
> --- smalltalk-2.0k/browser/ClassHierBrow.st Fri Feb 28 18:20:45 2003
> *************** compileMethod: aString for: aView
> *** 928,934 ****
>       curCategory isNil ifTrue: [
>    curCategory := (Prompter message: 'Enter method category'
>     default: 'As yet unclassified'
> !                 in: listView) response.
>
>    curCategory isEmpty ifTrue: [ curCategory := 'As yet unclassified' ]
>       ].
> --- 928,934 ----
>       curCategory isNil ifTrue: [
>    curCategory := (Prompter message: 'Enter method category'
>     default: 'As yet unclassified'
> !                 in: Shell) response.
>
>    curCategory isEmpty ifTrue: [ curCategory := 'As yet unclassified' ]
>       ].

Using listView is quite widespread.  I am not very much fond of changing it
because it works; it is part of the more general task of cleaning up the
browser's code.  I'd leave it as is until all of them are changed.

> diff -p smalltalk-2.0k.ori/browser/Debugger.st
smalltalk-2.0k/browser/Debugger.st
> *** smalltalk-2.0k.ori/browser/Debugger.st Sun Feb  9 19:38:32 2003
> --- smalltalk-2.0k/browser/Debugger.st Fri Feb 28 19:22:48 2003

ok

> diff -p smalltalk-2.0k.ori/browser/Menu.st smalltalk-2.0k/browser/Menu.st
> *** smalltalk-2.0k.ori/browser/Menu.st Sun Feb  9 11:21:18 2003
> --- smalltalk-2.0k/browser/Menu.st Fri Feb 28 19:20:04 2003
> *************** replaceArgWith: arg in: selectorsArray
> *** 59,65 ****
>       selectorsArray with: selectors
>    do:
>        [:item :changed |
> !      (item size > 2 and: [(item at: 2) numArgs > 1])
>     ifTrue: [changed at: 3 put: arg].
>
>        (item size > 1 and: [item last isArray]) ifTrue: [
> --- 59,65 ----
>       selectorsArray with: selectors
>    do:
>        [:item :changed |
> !      (item size > 2 and: [(item at: 2) numArgs = 1])
>     ifTrue: [changed at: 3 put: arg].
>
>        (item size > 1 and: [item last isArray]) ifTrue: [
>

The change should actually be to >= 1, not to = 1.  Will do that myself.

Paolo