[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] ParseTreeRewriter refactoring

From: Stephen Compall
Subject: Re: [Help-smalltalk] ParseTreeRewriter refactoring
Date: Thu, 11 Jan 2007 03:38:27 -0600

On Thu, 2007-01-11 at 09:57 +0100, Paolo Bonzini wrote:
> I'm not a big fan of computing selector names.  Sorry. :-(

That's too bad.  I liked them because those accept*: can be pushed up to
RBProgramNodeVisitor.  Is there another way to generalize
RBProgramNodeVisitor in such a fashion?

> However, I like visitNode:onMatch: and the acceptCascadeNode: fixes. 
> With your tests in hand I can take care of merging only those parts.

Might visitNodeList:visitor:onMatch: also be included and used where
relevant?  This gives just enough dynamism that my rewriter subclass
works without overriding accept*:.

Stephen Compall

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]