[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] shape review

From: Paolo Bonzini
Subject: [Help-smalltalk] shape review
Date: Sun, 21 Nov 2010 22:19:16 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6

Still to do:

1) use singletons.  Creating instances all the time is not acceptable.

2) no empty classes.

3) no empty methods returning self. Leave those unimplemented or use #subclassResponsibility.

4) methods such as wrongClassIfFloatShape: and wrongClassIfCharacterShape: make no sense. Just override checkArgumentClass: instead.

5) #shape: not implemented yet using shapes, as a result #resolveShape: is unused.

6) no class-method-only classes.  Move those to Shape.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]