Re: [Help-smalltalk] [PATCH] build: don't use obsolescent AM_PROG_CC_STDC and AM_CONFIG_HEADER

[Paolo Bonzini]

Il 13/05/2012 15:58, Stefano Lattarini ha scritto:
> The Automake-provided macros 'AM_PROG_CC_STDC' and 'AM_CONFIG_HEADER'
> have been superseded respectively by the Autoconf-provided ones
> 'AC_PROG_CC' (since October 2002) and 'AC_CONFIG_HEADERS' (since July
> 2002).  Moreover, those obsolescent macros will be removed in the next
> major Automake version (1.13).  Stop using them.
> 
> * configure.ac (AM_CONFIG_HEADER): Don't use this, ...
> (AC_CONFIG_HEADERS): ... use this instead.  While we are at it,
> properly quote the argument.
> * snprintfv/configure.ac (AM_PROG_CC_STDC): Drop this, the invocation
> to AC_PROG_CC is enough.
> 
> Copyright-paperwork-exempt: yes
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
> 
>  I've found these issues while trying to bootstrap GNU smalltalk with
>  the development version of Automake.
> 
>  Regards,
>    Stefano
> 
>  ChangeLog              |   16 ++++++++++++++++
>  configure.ac           |    2 +-
>  snprintfv/configure.ac |    1 -
>  3 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index b785ee4..8524244 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,19 @@
> +2012-05-13  Stefano Lattarini  <address@hidden> (tiny change)
> +
> +     build: don't use obsolescent AM_PROG_CC_STDC and AM_CONFIG_HEADER
> +
> +     The Automake-provided macros 'AM_PROG_CC_STDC' and 'AM_CONFIG_HEADER'
> +     have been superseded respectively by the Autoconf-provided ones
> +     'AC_PROG_CC' (since October 2002) and 'AC_CONFIG_HEADERS' (since July
> +     2002).  Moreover, those obsolescent macros will be removed in the next
> +     major Automake version (1.13).  Stop using them.
> +
> +     * configure.ac (AM_CONFIG_HEADER): Don't use this, ...
> +     (AC_CONFIG_HEADERS): ... use this instead.  While we are at it,
> +     properly quote the argument.
> +     * snprintfv/configure.ac (AM_PROG_CC_STDC): Drop this, the invocation
> +     to AC_PROG_CC is enough.
> +
>  2012-03-29  Paolo Bonzini  <address@hidden>
>  
>       * tests/compiler.st: Add testcase.
> diff --git a/configure.ac b/configure.ac
> index ec7f481..645416c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -19,7 +19,7 @@ AC_CONFIG_AUX_DIR([build-aux])
>  AC_CONFIG_MACRO_DIR([build-aux])
>  AC_CONFIG_SRCDIR([main.c])
>  AC_CONFIG_TESTDIR(tests)
> -AM_CONFIG_HEADER(config.h)
> +AC_CONFIG_HEADERS([config.h])
>  GST_PROG_GAWK
>  AM_INIT_AUTOMAKE
>  AC_CANONICAL_HOST
> diff --git a/snprintfv/configure.ac b/snprintfv/configure.ac
> index 59d7938..dbfd4f3 100644
> --- a/snprintfv/configure.ac
> +++ b/snprintfv/configure.ac
> @@ -110,7 +110,6 @@ AM_WITH_DMALLOC
>  # check for various programs used during the build.
>  # ----------------------------------------------------------------------
>  AC_PROG_CC
> -AM_PROG_CC_STDC
>  AC_C_CONST
>  AC_C_INLINE
>  AC_EXEEXT

Applied, thanks!

Paolo