[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] stinst: Fix the scanner for compile time co
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Help-smalltalk] [PATCH] stinst: Fix the scanner for compile time constants in literal arrays |
|
Date: |
Tue, 07 Jan 2014 11:29:55 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 01/01/2014 20:06, Holger Hans Peter Freyther ha scritto:
> > Hmm... What if #scanLiteralArrayParts was removed altogether, and the
> > logic to read the literals and find boundaries moved to RBParser? A
> > literal array's initial "#" can be represented by a RBLiteralArrayToken
> > that, like RBOptimizedToken, is just a placeholder for the starting
> > position of the array.
> >
> > RBParser then can convert RBBinarySelectorToken to a literal, and so on.
>
> yes, that makes sense. It is a bit beyond of what I have time for now.
> Maybe we will manage to get a Summer of Code student this year. :)
It's not that hard, even though it requires some changes to visitor
implementations. I'll post patches today.
Paolo