help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH] Process


From: Gwenaël Casaccio
Subject: Re: [Help-smalltalk] [PATCH] Process
Date: Tue, 25 Mar 2014 16:21:29 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 25/03/2014 16:15, Paolo Bonzini wrote:
Il 24/03/2014 10:50, Holger Hans Peter Freyther ha scritto:
-    startExecution: aDirectedMessage [
Is this code dead? Can we remove it right now?

Yes:

2006-12-28  Paolo Bonzini  <address@hidden>

         * libgst/interp.c: Remove commented out code to start call-ins through
         Process>>#startExecution:.

but please remove all remnants in libgst/ as well.

I hardly understand any of the changes in this patch, which is
scary.  While we have unit tests, you really need to explain
the changes and/or split them in multiple patches.

Paolo

This was not a patch but a work in progress in no way it should
have been included in that state.

Gwen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]