help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] [PATCH] prims: Bit-and the flags instead of using boole


From: Holger Hans Peter Freyther
Subject: [Help-smalltalk] [PATCH] prims: Bit-and the flags instead of using boolean operation
Date: Sat, 13 Sep 2014 20:25:24 +0200

This was pointed out by the clang compiler. Current access can
be either 0 or 1 but I think we want to be able to pass it as
integer as well. It looks like this code has never been executed
and we might just remove the call by number.

2014-09-13  Holger Hans Peter Freyther  <address@hidden>

        * prims.def: Use & instead of && for the flags value.
---
 libgst/ChangeLog | 4 ++++
 libgst/prims.def | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/libgst/ChangeLog b/libgst/ChangeLog
index a390754..e157c68 100644
--- a/libgst/ChangeLog
+++ b/libgst/ChangeLog
@@ -1,3 +1,7 @@
+2014-09-13  Holger Hans Peter Freyther  <address@hidden>
+
+       * prims.def: Use & instead of && for the flags value.
+
 2014-08-02  Holger Hans Peter Freyther  <address@hidden>
 
        * prims.def: Introduce VMpr_Behavior_newInitialize and
diff --git a/libgst/prims.def b/libgst/prims.def
index 431ec2b..98e5c68 100644
--- a/libgst/prims.def
+++ b/libgst/prims.def
@@ -5538,7 +5538,7 @@ primitive VMpr_FileDescriptor_fileOp [succeed,fail]
       if (IS_INT (oopVec[2]) && arg1 == PRIM_OPEN_FILE)
         {
           fd = open ((char *) fileName, TO_INT (oopVec[2]));
-         access = TO_INT (oopVec[2]) && (O_RDONLY | O_WRONLY | O_RDWR);
+         access = TO_INT (oopVec[2]) & (O_RDONLY | O_WRONLY | O_RDWR);
        }
 
       else if (!is_a_kind_of (OOP_CLASS (oopVec[1]), _gst_string_class))
-- 
2.1.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]