[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initiali
From: |
thomas |
Subject: |
Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new |
Date: |
Mon, 25 Jan 2016 21:48:31 +0000 |
Holger Freyther writes:
> If you select any "category" it gives you a dummy method you can alter
> and then use "Accept" to save it. The issue I see is that the template
> they provide is not correct syntax.
>
> method: selectors and: arguments
> "Comment describing purpose and answered value."
> | temporary variables |
> statements
>
>
> should be (the brackets):
>
> method: selectors and: arguments [
> "Comment describing purpose and answered value."
> | temporary variables |
> statements
> ]
>
>
> that is the "new" fileout syntax of GNU Smalltalk. Would you like to
> try to fix that, create a GNU changelog and use git format-patch to send
> the patch?
>
I've created a patch with just this mod, not including your previous
patch and it seems to work. Hopefully this is the correct format:
---
packages/blox/browser/ChangeLog | 7 +++++++
packages/blox/browser/ClassHierBrow.st | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/packages/blox/browser/ChangeLog b/packages/blox/browser/ChangeLog
index 5e77045..1107fa6 100644
--- a/packages/blox/browser/ChangeLog
+++ b/packages/blox/browser/ChangeLog
@@ -1,3 +1,10 @@
+
+2016-01-25 Thomas Weir Worthington <address@hidden>
+
+ * ClassHierBrow.st: updated method template to new
+ syntax
+
+
2016-01-23 Holger Hans Peter Freyther <address@hidden>
* BrowShell.st: Call >>#initialize.
diff --git a/packages/blox/browser/ClassHierBrow.st
b/packages/blox/browser/ClassHierBrow.st
index 93799d4..9d02c74 100644
--- a/packages/blox/browser/ClassHierBrow.st
+++ b/packages/blox/browser/ClassHierBrow.st
@@ -212,11 +212,11 @@ GuiData subclass: ClassHierarchyBrowser [
"Return add method template"
<category: 'accessing'>
- ^'method: selectors and: arguments
+ ^'method: selectors and: arguments [
"Comment describing purpose and answered value."
| temporary variables |
statements
-'
+]'
]
text [
--
2.4.10
- [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, Holger Hans Peter Freyther, 2016/01/23
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, thomas, 2016/01/24
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, Holger Freyther, 2016/01/24
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, thomas, 2016/01/24
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, Holger Freyther, 2016/01/24
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, thomas, 2016/01/25
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new,
thomas <=
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, Holger Freyther, 2016/01/27
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, thomas, 2016/01/28
- Re: [Help-smalltalk] [PATCH] blox: Fix fall-out from calling >>#initialize as part of new, Holger Freyther, 2016/01/28