[Koha-devel] Some little Bugfixes

[Andrés Tarallo]

While testing some funcionalities and coping with a few complains in the 
spanish translation I've found some little bugs in the OPAC and fixed 
them. Attached you'll find my modified files. I'm working with koha 2.1.2
#!/usr/bin/perl
use strict;
require Exporter;
use CGI;
use C4::Search;
use C4::Auth;
use C4::Bull; #uses getsubscriptionfrom biblionumber
use C4::Interface::CGI::Output;
use HTML::Template;
use C4::Biblio;
use C4::SearchMarc;

my $query=new CGI;
my ($template, $borrowernumber, $cookie) 
    = get_template_and_user({template_name => "opac-detail.tmpl",
                             query => $query,
                             type => "opac",
                             authnotrequired => 1,
                             flagsrequired => {borrow => 1},
                             });

my $biblionumber=$query->param('bib');
$template->param(biblionumber => $biblionumber);
# 2004-11-03 A. Tarallo The Subject was missing.
$template->param(subject => "1");


# change back when ive fixed request.pl
my @items                                 = &ItemInfo(undef, $biblionumber, 
'opac');
my $dat                                   = &bibdata($biblionumber);
my ($authorcount, $addauthor)             = &addauthor($biblionumber);
my ($webbiblioitemcount, @webbiblioitems) = &getwebbiblioitems($biblionumber);
my ($websitecount, @websites)             = &getwebsites($biblionumber);
my $subscriptionid = getsubscriptionfrombiblionumber($biblionumber);

$dat->{'count'address@hidden;

$dat->{'additional'}=$addauthor->[0]->{'author'};
for (my $i = 1; $i < $authorcount; $i++) {
        $dat->{'additional'} .= "|" . $addauthor->[$i]->{'author'};
} # for

my $norequests = 1;
foreach my $itm (@items) {
    $norequests = 0 unless $itm->{'notforloan'};
    $itm->{$itm->{'publictype'}} = 1;
}

$template->param(norequests => $norequests);

  ## get notes and subjects from MARC record
my $marc = C4::Context->preference("marc");
if ($marc eq "yes") {
        my $dbh = C4::Context->dbh;
        my $bibid = 
&MARCfind_MARCbibid_from_oldbiblionumber($dbh,$biblionumber);
        my $marcflavour = C4::Context->preference("marcflavour");
        my $marcnotesarray = &getMARCnotes($dbh,$bibid,$marcflavour);
        my $marcsubjctsarray = &getMARCsubjects($dbh,$bibid,$marcflavour);

        $template->param(MARCNOTES => $marcnotesarray);
        $template->param(MARCSUBJCTS => $marcsubjctsarray);
}

my @results = ($dat,);

my address@hidden;
my address@hidden;
my address@hidden;
my address@hidden;

$template->param(BIBLIO_RESULTS => $resultsarray,
                                ITEM_RESULTS => $itemsarray,
                                WEB_RESULTS => $webarray,
                                SITE_RESULTS => $sitearray,
                                subscriptionid => $subscriptionid,
);

output_html_with_http_headers $query, $cookie, $template->output;

#!/usr/bin/perl

# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA  02111-1307 USA

=head1 NAME

MARCdetail.pl : script to show a biblio in MARC format

=head1 SYNOPSIS


=head1 DESCRIPTION

This script needs a biblionumber in bib parameter (bibnumber
from koha style DB.  Automaticaly maps to marc biblionumber).

It shows the biblio in a (nice) MARC format depending on MARC
parameters tables.

The template is in <templates_dir>/catalogue/MARCdetail.tmpl.
this template must be divided into 11 "tabs".

The first 10 tabs present the biblio, the 11th one presents
the items attached to the biblio

=head1 FUNCTIONS

=over 2

=cut


use strict;
require Exporter;
use C4::Auth;
use C4::Context;
use C4::Output;
use C4::Interface::CGI::Output;
use CGI;
use C4::Search;
use MARC::Record;
use C4::Biblio;
use C4::Acquisition;
use HTML::Template;

my $query=new CGI;

my $dbh=C4::Context->dbh;

my $biblionumber=$query->param('bib');
my $bibid = $query->param('bibid');
$bibid = &MARCfind_MARCbibid_from_oldbiblionumber($dbh,$biblionumber) unless 
$bibid;
$biblionumber = &MARCfind_oldbiblionumber_from_MARCbibid($dbh,$bibid) unless 
$biblionumber;
my $itemtype = &MARCfind_frameworkcode($dbh,$bibid);
my $tagslib = &MARCgettagslib($dbh,1,$itemtype);

my $record =MARCgetbiblio($dbh,$bibid);
# open template
my ($template, $loggedinuser, $cookie)
                = get_template_and_user({template_name => 
"opac-ISBDdetail.tmpl",
                             query => $query,
                             type => "opac",
                             authnotrequired => 1,
                             debug => 1,
                             });

my $ISBD = C4::Context->preference('ISBD');
my @fields = $record->fields();
foreach my $field (@fields) {
        my $tag = $field->tag();
        if ($tag<10) {
        } else {
                my @subf = $field->subfields;
                for my $i (0..$#subf) {
                        my $subfieldcode = $subf[$i][0];
                        my $subfieldvalue = $subf[$i][1];
                        my $tagsubf = $tag.$subfieldcode;
                        $ISBD =~ 
s/\[(.?.?.?)$tagsubf(.*?)]/$1$subfieldvalue\[$1$tagsubf$2]$2$3/g;
                }
        }
}
$ISBD =~ s/\[(.*?)]//g;
$ISBD =~ s/\n/<br>/g;
# 2004-11-03 A. Tarallo  The parameter biblionumber isn't set.
$template->param(biblionumber => $biblionumber);
$template->param(ISBD => $ISBD);


output_html_with_http_headers $query, $cookie, $template->output;