Re: [Libcdio-devel] nrg audio not correct with dao

[R. Bernstein]

Robert William Fuller writes:
 > R. Bernstein wrote:
 > > Robert William Fuller writes:
 > >  > Seems NRG didn't handle DAO in read_audio_sectors.  Ask me how much fun 
 > >  > I had with /usr/bin/cmp figuring this out.  Here's a clue:
 > >  > 
 > >  >         cmp -l -i 0:352800 foo.bin /nfs/tmp/foo/foo.nrg
 > >  >         cmp: EOF on foo.bin
 > >  > 
 > >  > Note that 352800 is CDIO_PREGAP_SECTORS * 2352.
 > > 
 > > Wow! And can you guess the number I'm thinking of right now?  
 > 
 > I'm afraid I can.  Is it the number 0x4b000?  (Decimal 307200.) 

I just got it. Yes, that's it.

 > Incidentally, the function with that number in it also seems to be 
 > missing the line "env->pos.lba = 0;" which appears in its peers in 
 > cdrdao.c and bincue.c.  I'm pretty sure its absence is a bug.  

Yes, I think it's a bug. Because the value is 0 and structures tend to
get initallized with 0 (e.g. if calloc is used) it's probably not been
noticed. 

 > That will 
 > have to go on my list as well, but it will be pretty far down the list 
 > at this point.  Maybe someone else will pick this one up?

Just fixed. Thanks for finding/reporting.