Re: [Libcdio-devel] new cdtext interface

[Leon Merten Lohse]

Yes, that function is indeed missing. I did not implement it yet 
because I saw no need for it.

The track argument is not needed though, because the genre is set 
discwide.
That would make it

cdtext_genre_t cdtext_get_genre (const cdtext_t *p_cdtext) {
  if (NULL != p_cdtext)
    return CDTEXT_GENRE_UNUSED;
  return p_cdtext->block[p_cdtext->block_i].genre_code;
}

Regards
Leon


On 2012-10-16 02:47, Robert William Fuller wrote:
> I am confused by cdtext_genre2str(cdtext_genre_t i).  It expects a
> cdtext_genre_t, BUT no interface exposes a cdtext_genre_t.  Should
> there be another function?  Maybe it would look like this:
>
> cdtext_genre_t cdtext_get_genre (const cdtext_t *p_cdtext,  track_t 
> track);
>
> Am I missing something?
>
> Rob
>
> On 10/13/2012 01:26 PM, Leon Merten Lohse wrote:
> > Hi Rob,
> >
> > first of all, there are nearly no commercial disks, that have
> > multilanguage CD-Text.
> >
> > On 2012-10-13 14:27, Robert William Fuller wrote:
> > > Some questions about the new cdtext interface.
> > >
> > > Do I need to set the language? What language will I get if I do not
> > > set the language? Is there a default language? Will it return the
> > > first language on the disc?
> >
> > Default is the first language on the disc (block 0).
> >
> > > Does asking for track 0 still return the disc-level cdtext?
> >
> > Yes. The main difference is, that you now have one structure for the
> > whole disc.
> >
> > > When does libcdio read the cdtext on a real disc? Is this part of
> > > the TOC parsing? What function call is going to trigger reading the
> > > cdtext?
> >
> > Calling cdio_get_cdtext the first time will trigger the reading and
> > caching. It is not part of the TOC parsing. You have to call it
> > manually. If you are interested in the mmc, look at
> > mmc_read_cdtext_private in mmc/mmc.c.
> >
> > cdio_get_cdtext calls cdio_get_cdtext_raw, which you can do yourself 
> > if
> > you are interested int the binary data.
> >
> >
> > > I am asking in the interest of expediting my testing of the 
> > > upcoming
> > > release. If I do not get answers quickly, I will refer to the code.
> > >
> > > Thank you.
> > >
> > > Rob
> >
> > Thank YOU!
> >
> > Regards
> > Leon