Re: [Libcdio-devel] minor fixes for cross-compile friendliness

[Rocky Bernstein]

Patches should be in now. Not sure how to remove the nm warnings.

On Sat, Nov 19, 2016 at 3:27 PM, Ozkan Sezer <address@hidden> wrote:

> On 11/19/16, Rocky Bernstein <address@hidden> wrote:
> > Thanks for the patches. I don't see them attached in the email or in the
> > archive
> > http://lists.gnu.org/archive/html/libcdio-devel/2016-11/msg00000.html.
> >
>
> I did send the mail with attachments, but the list possibly has
> some sort of filtering
>
>
> > However best would be to add them at
> > https://savannah.gnu.org/patch/?func=additem&group=libcdio rather than
> in
> > any mailing list.
> >
>
> Done: https://savannah.gnu.org/patch/index.php?9167
>
>
> > To get rid of the nm warnings, configure with -with-versioned-libs.
> >
>
> Doesn't change anything for me.  I'm configuring for win64 with
> --host=x86_64-w64-mingw32
>
>
> > On Sat, Nov 19, 2016 at 10:11 AM, Ozkan Sezer <address@hidden> wrote:
> >
> >> Hi:  Attached are four small patches to libcdio, mostly for cross-
> >> compile friendliness.
> >>
> >>
> >> 0001: stdlib.h and string.h are needed for malloc, strlen and strncpy
> >>   in lib/driver/cdio_private.h
> >>
> >> 0002: do not call 'nm' directly, use the NM variable instead
> >>   in lib/driver/Makefile.am and lib/iso9660/Makefile.am
> >>
> >> 0003: check /bin/bash.exe result only if not cross-compiling
> >>   in configury.
> >>
> >> 0004: minor warning fixes (minor casts for format string in two places
> >>   in lib/driver/MSWindows/win32_ioctl.c and lib/iso9660/iso9660_fs.c.)
> >>
> >>
> >> There is one issue I could not handle:
> >>
> >> /usr/bin/nm: '.libs/freebsd.o': No such file
> >> /usr/bin/nm: '.libs/freebsd_cam.o': No such file
> >> /usr/bin/nm: '.libs/freebsd_ioctl.o': No such file
> >> /usr/bin/nm: '.libs/bincue.o': No such file
> >> /usr/bin/nm: '.libs/cdrdao.o': No such file
> >> /usr/bin/nm: '.libs/nrg.o': No such file
> >> /usr/bin/nm: '.libs/mmc.o': No such file
> >> /usr/bin/nm: '.libs/mmc_hl_cmds.o': No such file
> >> /usr/bin/nm: '.libs/mmc_ll_cmds.o': No such file
> >> /usr/bin/nm: '.libs/mmc_util.o': No such file
> >> /usr/bin/nm: '.libs/aspi32.o': No such file
> >> /usr/bin/nm: '.libs/win32_ioctl.o': No such file
> >> /usr/bin/nm: '.libs/win32.o': No such file
> >> /usr/bin/nm: '.libs/freebsd.o': No such file
> >> /usr/bin/nm: '.libs/freebsd_cam.o': No such file
> >> /usr/bin/nm: '.libs/freebsd_ioctl.o': No such file
> >> /usr/bin/nm: '.libs/bincue.o': No such file
> >> /usr/bin/nm: '.libs/cdrdao.o': No such file
> >> /usr/bin/nm: '.libs/nrg.o': No such file
> >> /usr/bin/nm: '.libs/mmc.o': No such file
> >> /usr/bin/nm: '.libs/mmc_hl_cmds.o': No such file
> >> /usr/bin/nm: '.libs/mmc_ll_cmds.o': No such file
> >> /usr/bin/nm: '.libs/mmc_util.o': No such file
> >> /usr/bin/nm: '.libs/aspi32.o': No such file
> >> /usr/bin/nm: '.libs/win32_ioctl.o': No such file
> >> /usr/bin/nm: '.libs/win32.o': No such file
> >>
> >> These warnings are from lib/driver/Makefile -> libcdio.la.ver rule.
> >> The sources have subdirectory paths in them and they aren't handled
> >> here.  I don't know what the best solution would be.
> >>
> >> Regards.
> >>
> >> --
> >> O.S.
> >>
> >
>
>