Re: [Libcdio-devel] [PATCH] Remove unnecessary high-memory safe wrapper for DosDevIOCtl() on OS/2

[KO Myung-Hun]

Hi/2.

Rocky Bernstein wrote:
> At the risk of going down a rabbit hole of OS2 stuff which I doubt many
> people use, (you are the only one I am aware of that has *ever* used
> libcdio), I wonder about this. Is there harm in having the wrapper there?
> 
> The last OS2 release was in 2000 with and end release date of 2006, a
> decade ago.
> 
> Removing the code above would force people to use
> <https://trac.netlabs.org/libc>kLIBC v0.6.6 <https://trac.netlabs.org/libc>,
> which I guess is an add-on.
> 
> I'd be grateful if you'd explain the harm of keeping the old code.
> 

Unfortunately, kLIBC v0.6.6 uses the same name as my wrapper. So call to
the wrapper leads into 'not enough memory' due to a recursive call.

kLIBC v0.6.6 has backward compatibility. As well as kLIBC v0.6.6
provides older versions of DLLs forwarding to v0.6.6. So even if people
upgrade their kLIBC to v0.6.6, they will not encounter any problem at
all. And most of all OS/2 users are already using kLIBC v0.6.6.

Not enough ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr