Re: [Libcdio-devel] [PATCH] Remove unnecessary high-memory safe wrapper for DosDevIOCtl() on OS/2

[KO Myung-Hun]

Hi/2.

Rocky Bernstein wrote:
> On Mon, Dec 12, 2016 at 6:12 AM, KO Myung-Hun <address@hidden> wrote:
> 
>>
>>
>> Rocky Bernstein wrote:
>>> Let's hold off applying the patches until
>>>
>>> 1. the FSF papers have gone through. (Have they?)
>>
>> Not yet.
>>
>>> 2. you have a server set up that I can access this and can
>>>     compile and test the code.
>>>
>>
>> No other ways than setting up a server ?
>>
>>> You have yet to give a reason as to why this can't be maintained as
>>> a separate repository.
>>>
>>
>> 1. Upstream code quality is always better than downstream because
>> submitted patches can be reviewed.
>>
> 
> I'll be happy to review changes in the OS/2 repository.
> 

Then, why is fork needed ?

> 
>> 2. It becomes harder and harder to maintain in forked repository with
>> time passed because patch sets are more and more.
>>
> 
> I  don't see that. You can  just go off a release that occurs now about
> once every year
> or two.  The os2 changes are basically confined to one file plus whatever
> tests there
> are.
> 

I think, this is true for libcdio repo itself.

> Hmm. That reminds me. There is currently no os2 driver test in tests/driver
> like
> there is for other os's. That probably needs to be fixed too.
> 

Ok.

> 
> 
>>> Others reading libcdio devel: is there anyone interested in seeing
>> libcdio
>>> continue
>>> on OS/2 and is willing to spend time on it?
>>>
>>>
>>>
>>>
>>> On Mon, Dec 12, 2016 at 4:53 AM, Rocky Bernstein <address@hidden> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Dec 12, 2016 at 3:34 AM, KO Myung-Hun <address@hidden> wrote:
>>>>
>>>>>
>>>>>
>>>>> Rocky Bernstein wrote:
>>>>>> On Fri, Dec 9, 2016 at 4:39 AM, KO Myung-Hun <address@hidden>
>> wrote:
>>>>>>
>>>>>
>>>>> [...]
>>>>>
>>>>>>>
>>>>>>> What I meant was how I could connect to the server of *other
>>>>>>> platforms/OSes* not OS/2.
>>>>>>>
>>>>>>
>>>>>> The only platform where we have remote access is for Solaris. When the
>>>>> FSF
>>>>>> stuff is squared, let's discuss
>>>>>> opencsw.org access then if you want access to that.
>>>>>>
>>>>>> For linux, OSX, and windows, libcdio developers have those OS's
>>>>> available
>>>>>> somehow so there's no need right now to have accessible via the
>>>>> Internet.
>>>>>>
>>>>>> OS/2 like Solaris and BSDi (when it was supported) are a bit different
>>>>> in
>>>>>> that they are less used and less common, and it is unreasonable to
>>>>> expect
>>>>>> libcdio developers to want to or have to run those to do testing.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> And should it be 24/7 ?
>>>>>>>
>>>>>>
>>>>>> No. With BSDi all that mattered is that when someone made a request to
>>>>> try
>>>>>> it, a BSDi box was spun up in a reasonable amount of time. And when
>>>>> actual
>>>>>> CD and DVD testing was done, there was a CD or DVD in the server. (Or
>>>>> not
>>>>>> if we needed no media)
>>>>>>
>>>>>
>>>>> It's possible to setup SSH server on OS/2. However, it's hard to run
>> the
>>>>> server publicly when requested. No other ways ?
>>>>>
>>>>
>>>> Sure, keep it running all the time. That work, and is less hassle on the
>>>> libcdio
>>>> developer side.
>>>>
>>>>
>>>>
>>>>>
>>>>> And I sent some patches. However, it does not include
>>>>> get_track_pregap_lba_os2(), because any drivers other than images did
>>>>> not implement it and libcdio describes that get_track_pregap_lba_os2()
>>>>> works on images.
>>>>>
>>>>
>>>> Ok. That make sense.
>>>>
>>>>>
>>>>> In case of SCSI sense reply, OS/2 DosDevIOCtl() seems not to support
>> it.
>>>>> So it's not possible in current implementation.
>>>>>
>>>>
>>>> Ok. Can the implementation be redone so we get a SCSI sense reply?
>>>>
>>>>
>>>>> --
>>>>> KO Myung-Hun
>>>>>
>>>>> Using Mozilla SeaMonkey 2.7.2
>>>>> Under OS/2 Warp 4 for Korean with FixPak #15
>>>>> In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
>>>>>
>>>>> Korean OS/2 User Community : http://www.ecomstation.co.kr
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>> --
>> KO Myung-Hun
>>
>> Using Mozilla SeaMonkey 2.7.2
>> Under OS/2 Warp 4 for Korean with FixPak #15
>> In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
>>
>> Korean OS/2 User Community : http://www.ecomstation.co.kr
>>
>>
>>
> 

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr