libjit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libjit] Getting started on the project, looking to contribute, have


From: Ben Vanik
Subject: Re: [Libjit] Getting started on the project, looking to contribute, have some questions
Date: Thu, 2 May 2013 08:12:47 -0700

Awesome! Thank you!

If there's any cleanup work that I can help with, please let me know!


--
Ben Vanik
http://www.noxa.org


On Thu, May 2, 2013 at 1:25 AM, Aleksey Demakov <address@hidden> wrote:
Hi Ben,

On Thu, May 2, 2013 at 10:58 AM, Ben Vanik <address@hidden> wrote:
e.g., are opcodes required to be implemented for all platforms or is a fallback intrinsic + at least one platform good enough? I don't have an ARM device so I wouldn't be able to provide that. What's the right way to add a test? The .pas files? Are those thorough or is there another way of testing that doesn't require learning Pascal?


It's okay to have intrinsics for awhile. DPas is the only test suite right now. I don't think it is needed to learn Pascal actually, just follow the existing examples. Admittedly a more comprehensive test suite is needed, perhaps a mixture of C-based tests and tests in some scripting languages, for instance based on jit-ruby. It would be great to have python bindings for libjit and then a python test suite.
 
When it comes to submitting a patch, how do you take it? Mailing a .patch to the list? A code review tool like Rietveld (https://code.google.com/p/rietveld/)?


Please submit your patches using savannah or alternatively just send them to the mailing list and/or to me directly.
 
Also, perhaps it's a good time to clean up some of the older files in the repo as for someone coming into the project new they are quite confusing. For example, the NEWS is anything but, the README references an author, company, and links that don't seem to be active in the project anymore, and it's difficult to tell what features are supported without reading the source code. Putting some information in a CONTRIBUTING file would help newbies like me from asking so many questions, too :)


Well, libjit has not ben actively maintained for a few years. I plan to get back to more active maintenance this summer, after I am done with the stuff I'm busy with right now.
 
Good to see some activity here, and I'm hoping to contribute!

You are welcome. 

Regards,
Aleksey


reply via email to

[Prev in Thread] Current Thread [Next in Thread]