libreboot-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lbwww-build][PATCH v1 2/5] configure.ac: Depend on grep


From: Denis 'GNUtoo' Carikli
Subject: Re: [lbwww-build][PATCH v1 2/5] configure.ac: Depend on grep
Date: Tue, 4 Apr 2023 16:27:50 +0200

On Mon,  3 Apr 2023 17:21:05 +0200
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> wrote:

> The grep command is required by untitled: If we remove grep in the
> guix shell and that we run make build, we end up with the following
> error:
>     Cleaning generated files from site: 'lbwww'
>     ./build: line 530: grep: command not found
>     ./build: line 530: grep: command not found
>     ./build: line 530: grep: command not found
>     www/lbwww/site.cfg does not specify DOMAIN. Exiting
>     make: *** [Makefile:585: build] Error 1
> 
> So it is a good idea to check for make as the build.sh script can also
> be used manually without Guix.
When thinking more about it, I think that the right way to do that is
probably to make guix optional (by adding some --without-guix argument
to configure) and then to check for grep only if guix is disabled. 

The bonus here is that it would make it much easier for people to test
their patch if they don't already have guix or don't want to invest
time into installing it.

Denis.

Attachment: pgpAtbWBXOSXo.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]