Re: [Libreplanet-dev] Calendar extension error

[John Sullivan]

Peter <address@hidden> writes:

> A much better approach would be to add an <event title="Event name" 
> icon="event/icon.png"/> tag, which users can put anywhere on the event page. 
> Calendar can search for it and properly parse it.
>
> Better yet, allow a single page to have several event tags and either combine 
> them into one calendar event, or display them separately.
>
> By using a tag, Calendar will be able to identify the event information and 
> validate it properly. Users will be able to edit the event page as they like 
> without compromising calendar, or the website. Pages without event tags can 
> be flagged in calendar as 'invalid event', so users can move or fix the page.
>

Sure, that all sounds nice. I don't see much of a problem with the
current approach though, after fixing this bug. 

>>
>> I fixed this particular one, but any fix to the extension itself would
>> be most welcome.
>
> By 'fixed' do you mean you changed the event page, or calendar code?
>

I mean I changed the event page so it wouldn't trigger the error
anymore.

> I _have_ _already_ offered my patch, has it been applied? It was submitted 
> about 5 days ago. If this is the wrong place to submit patches, please point 
> me to the right place.
>

We have a new intern on board who hopefully will be helping us with
Mediawiki issues. I'll ask him to look at the patch. 

But please do also submit it upstream (the calendar extension home page
is linked to from below the calendar). 

>>
>> We should probably also add an instruction somewhere (an event template
>> perhaps?) that says to use the first line as a title and not a link.
>
> Actually, Calendar _does_ expect the first line to have link, but doesn't 
> check it, my patch does that (I hope).
>
> Lets patch the code first and then see if it works with links before annoying 
> users and exposing the website to more abuse. Please.
>

Okay.

-- 
John Sullivan
Manager of Operations
GPG Key: AE8600B6