[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #10282] port libtool to grep 3.8 and to POSIX
From: |
Paul Eggert |
Subject: |
[patch #10282] port libtool to grep 3.8 and to POSIX |
Date: |
Tue, 20 Sep 2022 02:44:00 -0400 (EDT) |
Follow-up Comment #3, patch #10282 (project libtool):
[comment #2 comment #2:]
> Did you test to see if the new pattern still works with `grep` < 3.8 by any
chance?
Yes, it works.
> Just to check my understanding here: the intention of `[[-]]L` is to escape
`"[-]L"` in M4, taking advantage of the old `grep "[-]-not-an-option";` trick
to force grep to recognize argument 1 as a pattern rather than a flag?
Yes, that's right.
> The one I didn't totally understand was removing the `@<:@` handler; mostly
because I don't remember the context off hand.
Without the patch, a test is generated that runs a shell command like this:
grep '\]'
This usage of grep is not portable, since POSIX says that the regular
expression \] has undefined effect (unlike \[ which is well defined to match
an opening square bracket). A failure of the test does not mean that grep is
broken; it means libtool is broken. To fix libtool, we should remove the
incorrect test.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/patch/?10282>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/