Re: [Libunwind-devel] Power Libunwind

[Jose Flavio Aguilar Paulino]

Hi David,

I have already changed the copyright headers, what happened was that I
just copied the headers of others libunwind files.
I was already debugging the powerpc64 libunwind, and the work around I
used to solve the function address does no work.
I really need a function in elfxx to translate the function address.
This happens because there are sections with this toc structure:
typedef struct
{
  unsigned long entry;
  unsigned long toc;
  unsigned long env;
} func_descr_t;

In power everytime I have a branch to a function the branch refers to
this a toc table with entries like the above.

Maybe we should put a common file for the x86 archs that do not
translate the function pointer, just return the same.

What you and the community thinks?
  
Thanks, 
Flavio


On Tue, 2007-07-31 at 10:14 -0600, David Mosberger-Tang wrote:
> Hi Jose,
> 
> I was gonna merge this patch, but then I noticed it still has several
> files/mention of *get_func_addr().  Did you mean to get rid of those
> completely (they're mentioned even for x86)?  Could you do that?
> Also, I'm a bit nervous about the copyright headers for files that you
> created.  For example:
> 
> +   Copyright (C) 2002-2004 Hewlett-Packard Co
> +     Contributed by David Mosberger-Tang <address@hidden>
> +
> +   Copied from libunwind-x86_64.h, modified slightly for building
> +   frysk successfully on ppc64, by Wu Zhou <address@hidden>
> +   Will be replaced when libunwind is ready on ppc64 platform.
> 
> I'd suggest to prefix the first two lines with something along the lines of:
> 
> +  Derived from a file which is:
> +     Copyright (C) ....
> 
> Also, it would be good to have your name in there, so I'll remember
> who to bug... ;-)
> 
> Other than that, the patch looks great!
> 
> Thanks,
> 
>   --david
> 
> On 7/27/07, Jose Flavio Aguilar Paulino <address@hidden> wrote:
> > The patch revised as asked.
> >
> > regards,
> > Jose Flavio
> >
> > _______________________________________________
> > Libunwind-devel mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/libunwind-devel
> >
> >
> >
> 
>