Re: [Libunwind-devel] [patch] mark stack non-executable

[David Mosberger-Tang]

Hi Mark,

The patch looks fine to me.  I added it to the GIT tree and the alpha tar ball.

Thanks!

  --david

On 10/1/07, Mark Wielaard <address@hidden> wrote:

Hi,

On some systems executable stacks are denied. Since libunwind and the
tests don't actually need executable stacks this patch marks all
assembly files as not needing it.

The original patch comes from frysk:

2007-04-05  Jan Kratochvil  <address@hidden>

     * src/hppa/getcontext.S, src/hppa/setcontext.S, src/hppa/siglongjmp.S,
     src/ia64/Ginstall_cursor.S, src/ia64/Linstall_cursor.S,
     src/ia64/dyn_info_list.S, src/ia64/getcontext.S, src/ia64/longjmp.S,
     src/ia64/setjmp.S, src/ia64/siglongjmp.S, src/ia64/sigsetjmp.S,
     src/ppc64/longjmp.S, src/ppc64/siglongjmp.S, src/x86/longjmp.S,
     src/x86/siglongjmp.S, src/x86_64/longjmp.S, src/x86_64/setcontext.S,
     src/x86_64/siglongjmp.S: Stack should be non-executable, for SELinux.

I added a couple more markers for new files in current libunwind.

Before this patch you would get the following on selinux enabled systems
without allow_exec_stack: error while loading shared libraries:
libunwind.so.7: cannot enable executable stack as shared object
requires: Permission denied
After the patch that error disappears and all test results are similar
to the results on systems without executable stack protection.

Cheers,

Mark

_______________________________________________
Libunwind-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/libunwind-devel

-- 
Mosberger Consulting LLC, http://www.mosberger-consulting.com/