[Libunwind-devel] Re: [patch] Reduce Linux stack use.

[Paul Pluzhnikov]

On Wed, Oct 7, 2009 at 12:45 PM, Arun Sharma <address@hidden> wrote:

>> -  char path[PATH_MAX], *cp;
>> +  char path[sizeof ("/proc/01234567879/maps")], *cp;
>>
> Did you mean 789 and not 7879 above?

Yes, that's a typo.

> There seems to be an implicit assumption that size of pid_t is <= 32
> bits (which seems to be true for all archs supported by linux). Since
> you have an assert to check that, I'm ok with this change.

Right.

>> -      if (i < buf_size - 1)
>> +      if (valp != NULL && i < buf_size - 1)
>
> Prefer parens around expressions.
>
> I'll go ahead and make these two changes and apply.

Thanks,
-- 
Paul Pluzhnikov