Re: [Libunwind-devel] FreeBSD port

[Konstantin Belousov]

On Wed, Mar 31, 2010 at 09:56:55AM -0700, Arun Sharma wrote:
> On Wed, Mar 31, 2010 at 6:26 AM, Konstantin Belousov <address@hidden>wrote:
> 
> > Hello,
> > please find at the http://people.freebsd.org/~kib/git/libunwind.git
> > a port of libunwind HEAD to FreeBSD i386/amd64. I think I implemented
> > all missing pieces, and I know that basic unwinding for both
> > arches works. Some testing was done on FreeBSD RELENG_8, I think it
> > should work the same on HEAD.
> >
> 
> Thanks for the port! I was able to check out your git tree. Apart from this
> minor change:
> 
> --- a/configure.in
> +++ b/configure.in
> @@ -25,7 +25,7 @@ dnl Checks for libraries.
>  AC_CHECK_LIB(uca, __uc_get_grs)
>  AC_CHECK_LIB(util, kinfo_getvmmap)
>  OLD_LIBS=${LIBS}
> -AC_SEARCH_LIBS(dl, dlopen)
> +AC_SEARCH_LIBS(dlopen, dl)
>  LIBS=${OLD_LIBS}
>  case "$ac_cv_search_dlopen" in
>    -l*) DLLIB=$ac_cv_search_dlopen;;
> 
> there were no regressions on Linux/x86_64.
Marvellous, I do not possess a linux machine. Thanks for the testing, I
committed your fix.

> 
> I haven't looked at the rest of the changes in more detail - but nothing
> jumped out at me. It might be easier to maintain the library if we break the
> files with largish #ifdef linux/freebsd into separate files.
Sure. Would you structure the main trunk as you find appropriate, and
them I add freebsd bits in the place ? Or do you want me to do
the separation ?

> 
> I'll do another pass over it hopefully in the next couple of days.
Looking forward for the review, thanks.

pgp7ywOTChUsP.pgp
Description: PGP signature