Re: [Libunwind-devel] FreeBSD port

[Arun Sharma]

On Wed, Mar 31, 2010 at 11:06:53PM +0300, Konstantin Belousov wrote:
> > 
> > I haven't looked at the rest of the changes in more detail - but nothing
> > jumped out at me. It might be easier to maintain the library if we break the
> > files with largish #ifdef linux/freebsd into separate files.
> Sure. Would you structure the main trunk as you find appropriate, and
> them I add freebsd bits in the place ? Or do you want me to do
> the separation ?

Sure - I'll give it a shot.

> 
> > 
> > I'll do another pass over it hopefully in the next couple of days.
> Looking forward for the review, thanks.

* configure.in

AC_CHECK_DECLS: Is there is a simpler solution to the problem?

* os-freebsd.c

Could you please indent it similar to the rest of the library?

* _UPT_find_proc_info.c

Are these portability changes or required for correctness?

* make check

- two tests didn't compile for me on FreeBSD 8
  - rs-race.c - missing prototype for backtrace(). Install execinfo port
    made it go away. Perhaps this needs an autoconf check?
  - Gtest-dyn1.c: FreeBSD doesn't like malloc.h
  
- Gtest-exc.c fails with

Program received signal SIGILL, Illegal instruction.
_Ux86_64_setcontext () at x86_64/setcontext.S:70
70              sysenter
Current language:  auto; currently asm

(gdb) bt
#0  _Ux86_64_setcontext () at x86_64/setcontext.S:70
#1  0x00007fffffffe4b0 in ?? ()
#2  0x000000080076b182 in _ULx86_64_local_resume (as=Variable "as" is not 
available.
) at Gresume.c:84
#3  0x000000080076b139 in _ULx86_64_resume (cursor=0x7fffffffe0b0) at 
Gresume.c:140
#4  0x0000000000400a90 in raise_exception () at Gtest-exc.c:72
#5  0x0000000000400ae9 in b (n=3) at Gtest-exc.c:128

The libc on my system seems to be using "syscall" rather than the "sysenter" 
instruction.

More after I've refactored the code a bit in preparation for pulling the
code.

 -Arun