libunwind-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to l


From: Arun Sharma
Subject: Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind
Date: Mon, 12 Mar 2012 20:26:52 -0700

I copied your patches + some build fixes for x64 to:

https://github.com/adsharma/libunwind/commits/coredump2

Please verify that everything still works on your end. Some loose ends
to be tied up before I can push to libunwind HEAD:

* tests/test-coredump-unwind doesn't test anything right now. An
actual test that fails if future commits break things would be great.
This might require a test core dump file for every platform you care
about.

* _UCD_libs.h seems to have a different license. Please let me know if
relicensing is possible.

* I suspect ia64 is broken by 2.patch

$ grep -i ia64 src/dwarf/Gfind_unwind_table.c
#if UNW_TARGET_IA64

ia64 is not a dwarf platform and shouldn't be  using stuff under
src/dwarf. Please send me an incremental diff to move that code back
to the original location.

People working on other platforms: please verify that this works for
you (or at least doesn't break anything).

 -Arun

PS: git clone -b coredump2 git://github.com/adsharma/libunwind.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]