libunwind-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] [PATCH 1/7] ppc32: ppc64: use AC_COMPILE_IFELSE to


From: Cody P Schafer
Subject: Re: [Libunwind-devel] [PATCH 1/7] ppc32: ppc64: use AC_COMPILE_IFELSE to test __powerpc64__ macro for ppc64
Date: Wed, 05 Sep 2012 10:40:14 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0

On 09/04/2012 11:24 PM, Tommi Rantala wrote:
2012/9/4 Cody P Schafer <address@hidden>:
-is_gcc_m64() {
- if test `echo $CFLAGS | grep "\-m64" -c` -eq 1 ; then echo ppc64;
- else
-  if test `echo $CC | grep "\-m64" -c` -eq 1 ; then echo ppc64; else echo 
ppc32; fi;
- fi;
-}
+


Sorry for nitpicking, but do we want two empty lines here?

No we don't, will fix.

The patch looks otherwise good, grepping CFLAGS and CC was horrible.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]