Re: [Libunwind-devel] [PATCH 14/19] Provide manual page for `unw_backtrace()'

[Lassi Tuura]

Heya,

Thanks for the docs improvements!

You might be able to lift useful fragments from the comments (e.g.
http://git.savannah.gnu.org/gitweb/?p=libunwind.git;a=blob;f=src/x86_64/Gtrace.c;h=446610cbdf4dff330b690232656743ccbb708c31;hb=HEAD#l333).
The user-visible unw_backtrace() API does the fallback mentioned
there.

Perhaps call out on the man page that unw_backtrace() is async signal
safe and suitable for use within malloc(), profilers and other tricky
corners? The system backtrace() may not be - often isn't. If you do
mention this, perhaps also mention under BUGS a risk of deadlocks in
_dl_iterate_phdr() and crashes from bad unwind info? These are general
properties of libunwind, not of unw_backtrace() specifically.

>>> +.PP
>>> +David Mosberger\-Tang
>>> +.br
>>> +Email: address@hidden
>>
>> Please list Lassi Tuura <address@hidden> as a co-author here.
>
> Lassi, do you want to be personally attributed, or shall all the
> credit go to your employer similar to the copyright notices in the
> source files?

My preference would be "Lassi Tuura, Fermilab <address@hidden>".

Regards,
Lassi