Re: [Libunwind-devel] [PATCH] Create and install pkg-config .pc files

[Alexander Toresson]

On Mon, Sep 17, 2012 at 10:23 PM, Alexander Toresson
<address@hidden> wrote:
> On Sat, Sep 15, 2012 at 8:43 PM, Arun Sharma <address@hidden> wrote:
>> On Mon, Sep 3, 2012 at 11:04 PM, Alexander Toresson
>> <address@hidden> wrote:
>>> On Tue, Sep 4, 2012 at 6:21 AM, Arun Sharma <address@hidden> wrote:
>>>> On Wed, Aug 29, 2012 at 6:10 AM, Tommi Rantala <address@hidden> wrote:
>>>>> Hi,
>>>>>
>>>>> "libunwind-$arch.pc" could be also named "libunwind-generic.pc", and
>>>>> use "-lunwind-generic" for linking. This is suggested in the NEWS
>>>>> file, and also in doc/libunwind-ptrace.man.
>>>>>
>>>>> Also, if building a cross-unwinder e.g. with "./configure
>>>>> --target=arm-linux-gnueabi", only "libunwind-$arch.so" is created. In
>>>>> this case only one of the pkgconfig files would be needed, and the
>>>>> dependencies would be different too.
>>>>
>>>> Alexander: are you still working on a patch which addresses Tommi's 
>>>> comments?
>>
>> I applied this patch with Tommi's suggested changes. Please take a look.
>>
>>  -Arun
>
> Great, thank you!
>
> Here are some comments:
>
> +                src/libunwind-generic.pc:src/libunwind-generic.pc.in)
>
> You can just specify src/libunwind-generic.pc and it will find
> src/libunwind-generic.pc.in automatically; using this syntax was
> necessary earlier when different files were created from the same
> input file.
>
> +Requires: address@hidden@ libunwind
>
> (for both libunwind-coredump.pc.in and libunwind-ptrace.pc.in)
>
> This should say libunwind-generic instead of address@hidden@, as it
> was renamed :)
>
> Thanks, Alexander  Toresson

Forgot to reply to the list too.

// Alexander