[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] patch to break out of loop when dwarf_step and is_
|
From: |
Konstantin Belousov |
|
Subject: |
Re: [Libunwind-devel] patch to break out of loop when dwarf_step and is_signal_frame fail on x86 |
|
Date: |
Sun, 10 Mar 2013 08:51:25 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Mar 09, 2013 at 10:10:37PM -0800, Arun Sharma wrote:
> On Thu, Mar 7, 2013 at 10:25 AM, dave lerner <address@hidden> wrote:
>
> > Thanks to all the developers for the work on this well designed,
> > implemented, and usefull package.
> >
> > I have an issue and proposed fixed attached below with the x86 frame based
> > signal unwinder. Hans Boehm seems like a likely reviewer.
> >
>
> Thanks for tracking this down. The same issue seems to exist in
> Gos-freebsd.c. Does the attached patch work for you?
I think that Gos-freebsd.c:unw_is_signal_frame() is not affected, at
least it seems so from the code reading. The function starts with
the assignment of the X86_SCF_NONE to the ret, and the ret value is not
changed in the case access_mem error.
pgpLuEHtG_91V.pgp
Description: PGP signature