libunwind-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Libunwind-devel] [PATCH] Do not compute load offset for MiniDebugInfo


From: Martin Milata
Subject: [Libunwind-devel] [PATCH] Do not compute load offset for MiniDebugInfo
Date: Fri, 6 Jun 2014 13:27:03 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

It appears that this patch has been lost. Could you please consider
merging it?

-->8-->8-->8-->8-->8--

We already have the value computed based on the executable. Furthermore,
debuginfo need not have valid program header table, thus the result
might be bogus.

Signed-off-by: Martin Milata <address@hidden>
---
 src/elfxx.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/elfxx.c b/src/elfxx.c
index 3d87331..8443553 100644
--- a/src/elfxx.c
+++ b/src/elfxx.c
@@ -318,11 +318,8 @@ elf_w (get_proc_name_in_image) (unw_addr_space_t as, 
struct elf_image *ei,
   struct elf_image mdi;
   if (elf_w (extract_minidebuginfo) (ei, &mdi))
     {
-      int ret_mdi;
-
-      load_offset = elf_w (get_load_offset) (&mdi, segbase, mapoff);
-      ret_mdi = elf_w (lookup_symbol) (as, ip, &mdi, load_offset, buf,
-                                      buf_len, &min_dist);
+      int ret_mdi = elf_w (lookup_symbol) (as, ip, &mdi, load_offset, buf,
+                                          buf_len, &min_dist);
 
       /* Closer symbol was found (possibly truncated). */
       if (ret_mdi == 0 || ret_mdi == -UNW_ENOMEM)
-- 
1.7.11.7



reply via email to

[Prev in Thread] Current Thread [Next in Thread]