Re: [Libunwind-devel] Add TileGx platform support

[Zhigang Liu]

This is the URL of the git repo. at the github.  Can you give a code review?

https://github.com/zliu2014/libunwind-tilegx

ZhiGang @ Tilera

---

From: Zhigang Liu
Sent: Wednesday, September 03, 2014 1:50 PM
To: address@hidden
Subject: Add TileGx platform support

Hi,

 

Below is the git repo. for Tilegx support. Please CR.

 

address@hidden:zliu2014/libunwind-tilegx.git

 

Thanks

 

ZhiGang @ Tilera

 

 

PS:

$make check

…

PASS: test-proc-info

PASS: test-static-link

PASS: test-strerror

PASS: Gtest-bt

PASS: Ltest-bt

PASS: Gtest-exc

PASS: Ltest-exc

PASS: Gtest-init

PASS: Ltest-init

PASS: Gtest-concurrent

PASS: Ltest-concurrent

PASS: Gtest-resume-sig

PASS: Ltest-resume-sig

PASS: Gtest-resume-sig-rt

PASS: Ltest-resume-sig-rt

FAILURE: expected 13, not 1 frames below signal frame

XFAIL: Gtest-dyn1

FAILURE: expected 13, not 1 frames below signal frame

XFAIL: Ltest-dyn1

PASS: Gtest-trace

PASS: Ltest-trace

PASS: test-async-sig

PASS: test-flush-cache

PASS: test-init-remote

PASS: test-mem

PASS: Ltest-varargs

PASS: Ltest-nomalloc

PASS: Ltest-nocalloc

PASS: Lrs-race

PASS: test-ptrace

PASS: test-setjmp

PASS: run-check-namespace

PASS: run-ptrace-mapper

PASS: run-ptrace-misc

PASS: run-coredump-unwind

PASS: run-coredump-unwind-mdi

======================================================

All 34 tests behaved as expected (2 expected failures)

======================================================

 

$make perf

########## Basic performance of generic libunwind:

unw_getcontext : cold avg=  431.538 nsec, warm avg=  381.470 nsec

unw_init_local : cold avg=13129.711 nsec, warm avg= 6380.081 nsec

no cache        : unw_step : 1st=16827.810 min=15924.090 avg=16056.541 nsec

global cache    : unw_step : 1st= 7895.061 min= 6371.453 avg= 6460.625 nsec

per-thread cache: unw_step : 1st= 6762.005 min= 6380.535 avg= 6551.438 nsec

########## Basic performance of local-only libunwind:

unw_getcontext : cold avg=  438.690 nsec, warm avg=  388.622 nsec

unw_init_local : cold avg=13461.113 nsec, warm avg= 6620.884 nsec

no cache        : unw_step : 1st=13496.762 min=12799.672 avg=13035.655 nsec

global cache    : unw_step : 1st= 7420.494 min= 5951.382 avg= 6155.273 nsec

per-thread cache: unw_step : 1st= 6192.071 min= 5960.464 avg= 6158.611 nsec

########## Performance of fast unwind:

unw_getcontext : cold avg=  438.690 nsec, warm avg=  388.622 nsec

unw_init_local : cold avg=13430.119 nsec, warm avg= 6709.099 nsec

no cache        : unw_step : 1st=13819.195 min=12933.640 avg=13191.357 nsec

global cache    : unw_step : 1st= 7608.959 min= 6180.718 avg= 6378.568 nsec

per-thread cache: unw_step : 1st= 6580.353 min= 6180.718 avg= 6343.447 nsec

########## Startup overhead:

"/bin/true"                                                                                     : 2110227 nsec/execution

"LD_PRELOAD=../src/.libs/libunwind.so /bin/true"              : 3405604 nsec/execution

"LD_PRELOAD=../src/.libs/libunwind-tilegx.so /bin/true"   : 4016310 nsec/execution

 

Overhead of preloading ../src/.libs/libunwind.so   : 1295377 nsec

Overhead of preloading ../src/.libs/libunwind-tilegx.so      : 1906083 nsec

 

 

 

 

 

 

 

 

From: libunwind-devel-bounces+address@hidden [mailto:libunwind-devel-bounces+address@hidden On Behalf Of Zhigang Liu
Sent: Tuesday, August 26, 2014 4:12 PM
To: address@hidden
Subject: [Libunwind-devel] How to submit a patch?

 

Hi,

 

I am new to this mail list. I am going to submit a patch to support Tilera’s TileGx platform.

Question: what is the procedure to submit a patch ?  

 

Thanks for the help.

 

ZhiGang @ Tilera