[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH] Fix intermittent failures of Lrs-race test
|
From: |
Simon Atanasyan |
|
Subject: |
Re: [Libunwind-devel] [PATCH] Fix intermittent failures of Lrs-race test case |
|
Date: |
Sun, 26 Oct 2014 23:26:02 +0400 |
On Sat, Oct 25, 2014 at 10:14 AM, Arun Sharma <address@hidden> wrote:
> On Fri, Oct 24, 2014 at 3:05 AM, Simon Atanasyan <address@hidden> wrote:
>> When we include "config.h" into the "libunwind_i.h" we undefine
>> the HAVE___THREAD macro in a few lines below in #include "config.h"
>> pragma. The change eac65dc includes "config.h" into the "dwarf.h"
>> but forgets to undefine HAVE___THREAD. So now this macro has inconsistent
>> state among the code. Somewhere it is defined, somewhere not. In particular
>> it becomes defined in the mi/Gset_caching_policy.c and we do not replace
>> UNW_CACHE_PER_THREAD caching policy by the UNW_CACHE_GLOBAL.
>>
>
> Thanks for tracking it down. I pushed your both patches to git.
Thanks for quick review and committing the patches.
--
Simon Atanasyan