Re: [Libunwind-devel] [PATCH] Fix build from scratch

[Thomas Petazzoni]

Dear Arun Sharma,

On Tue, 2 Dec 2014 22:15:55 +0530, Arun Sharma wrote:
> On Tue, Dec 2, 2014 at 10:08 PM, Thomas Petazzoni
> <address@hidden> wrote:
> 
> >
> > So I definitely support Olivier's patch making latex2man optional, and
> > the idea of having an explicit --disable-documentation option. It is
> > definitely great to make this optional, and autoconf is designed for
> > making this possible.
> >
> 
> Sounds reasonable. Why not:
> 
> +AC_PATH_PROG([LATEX2MAN],[latex2man])
> +if test "x$LATEX2MAN" = "x"; then
> +  AC_MSG_WARN([latex2man not found. Install latex2man. Disabling docs.])
> +  enable_documentation="no"
> +fi

That's fine with me. Though maybe you still need the AC_CONFIG_FILES
changes that were originally in Olivier's patch, no?

> Also, make this line in Makefile.am conditional?
> 
> > SUBDIRS = src tests doc

Yes. Ideally, building tests would also be conditional. They actually
don't build with uClibc, we have a patch to disable building of tests
in Buildroot:
http://git.buildroot.net/buildroot/tree/package/libunwind/0001-disable-tests.patch.
But that's a separate issue.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com